-
Notifications
You must be signed in to change notification settings - Fork 19
[macOS] Security events #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add file path to Security events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change needed for 8.18 or 9.0?
| - file.path | ||
| - file.code_signature.signing_id | ||
| - file.code_signature.team_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These three fields look out of alphabetical order.
| | file.path | | ||
| | file.code_signature.signing_id | | ||
| | file.code_signature.team_id | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These file fields look out of alphabetical order.
|
@ferullo 9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update package/endpoint/data_stream/security/sample_event.json with example values for
file.pathfile.code_signature.signing_idfile.code_signature.team_id
Other than that, this looks ok to squeeze into 9.0, if we can merge soon
|
@ashokaditya reordered the fields in alphabetical order |
|
@ricardo-estc content of PR looks good, I think CI error is just about formatting on that sample event json. I'm guessing the space after the key names and before the |
…endpoint-package into ricardo/add_file_security_event
Add file path to Security events
Change Summary
Sample values
Sample document:
Release Target
Q/A
For mapping changes:
makeafter making the schema changes, and committed all changesmetadatachange, I also updated both transform destination schemas to matchFor Transform changes: