-
Notifications
You must be signed in to change notification settings - Fork 19
Add fields connected to rules and alerts #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1467f5c
c0c1222
4c72d1e
27fdfb6
fbbfd93
6fa6940
156e22a
fefc7c2
92f73cc
f1a39de
707eac3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,10 @@ fields: | |
| agent: | ||
| fields: | ||
| id: {} | ||
| rule: | ||
| fields: | ||
| id: {} | ||
| name: {} | ||
|
Comment on lines
+26
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Q: Do we need these fields also in the response index? If yes then we need to add this to the |
||
| error: | ||
| fields: | ||
| code: {} | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. The fact that this is a
keywordwe can store an array of strings here s, so you can have multiple alert ids in the doc. Just that we should conform to ECS naming best practices.