Adds a constant to check GeoJSON RFC7946 testing and building #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
nickpeihl
approved these changes
Jan 4, 2022
| const reader = new jsts.io.GeoJSONReader(); | ||
| const fc = reader.read(geojson); | ||
| const fieldsNames = fieldMap.map(f => f.name).sort(); | ||
| t.ok(fc.features.every(feat => feat.geometry.isSimple() | ||
| ), 'All geometries must be simple'); | ||
| ), `All geometries from ${fileName} must be simple`); |
There was a problem hiding this comment.
Adding the fileName is very helpful. Thank you!
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #231
This PR adds a new constant
GEOJSON_RFC7946, set toundefinedat this moment to not change the current results of tests and build, leaving the definition of this behavior for a follow-up PR when discussion in #231 is concluded.When set to
trueto enforce the RFC7946 standard for polygon orientation in GeoJSON files, the build process will ensure that all published polygons in all data layers are counter-clockwise oriented. When testing withEMS_STRICT_TESTenv var defined, it will report which data layers are not following the standard.When set to
falseit will build all polygons clockwise oriented and withEMS_STRICT_TESTit will report the data layers that follow the RFC7946 standard and are being rewind'ed in the build process.Screenshots of test executions with EMS_STRICT_TEST
GEOJSON_RFC7946 = undefinedno changes in build and test results:
GEOJSON_RFC7946 = trueThere are 62 files that are not following the standard.
GEOJSON_RFC7946 = falseThere are 20 files that follow the standard and are consequently reported by the tests.