Delete index folder if all shards were allocated away from a data only node #9985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger.debug("{} failed to delete unallocated shard, ignoring", ex, shardId); | ||
| } | ||
| // if the index doesn't exists anymore, delete its store as well, but only if its a non master node, since master | ||
| // nodes keep the index metadata around | ||
| if (indicesService.hasIndex(shardId.getIndex()) == false && currentState.nodes().localNode().masterNode() == false) { |
There was a problem hiding this comment.
Just wondering why would master nodes want to keep the index directories around?
|
LGTM |
brwe
added a commit
that referenced
this pull request
Mar 5, 2015
…ata only node If a folder for an index was created that folder is never deleted from that node unless the index is deleted. Data only nodes therefore can have empty folders for indices that they do not even have shards for. This commit makes sure empty folders are cleaned up after all shards have moved away from a data only node. The behavior is unchanged for master eligible nodes. closes #9985
| } | ||
| ClusterState clusterState = clusterService.state(); | ||
| if (clusterState.metaData().hasIndex(indexName)) { | ||
| if (clusterState.metaData().hasIndex(indexName) && (clusterState.nodes().localNode().masterNode() == true)) { |
There was a problem hiding this comment.
in this case isn't the exception wrong? I mean shouldn't we just skip it in that case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a folder for an index was created that folder is never deleted from that node unless the index is deleted.
Data only nodes therefore can have empty folders for indices that they do not even have shards for.
This commit makes sure empty folders are cleaned up after all shards have moved away from a data only
node. The behavior is unchanged for master eligible nodes.
I changed the
testShardActiveElseWheretest to sometimes use data only nodes, not sure if this is useful. Also I added the check forclusterState.metaData().hasIndex(indexName)inIndicesService.deleteIndexStoreagain. Did not come up with a better way to solve this.