Skip to content

[8.10] Set default index mode for TimeSeries to null (#98808) #98866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

kkrik-es
Copy link
Contributor

Backports the following commits to 8.10:

* Skip segment for MatchNoDocsQuery filters.

When a query of a filter gets rewritten to MatchNoDocsQuery, segments
will not produce any results. We can therefore skip processing such
segments.

This applies to FilterByFilterAggregator and FiltersAggregator, as well
as to TermsAggregator when it uses StringTermsAggregatorFromFilters
internally; the latter is an adapter aggregator to
FilterByFilterAggregator.

Fixes elastic#94637

* Update docs/changelog/98295.yaml

* Check all filters for `MatchNoDocsQuery`.

* Skip optimization when 'other' bucket is requested.

* Revert "Set default index mode for TimeSeries to `null` (elastic#98586)"

This reverts commit 56abb86.

* Revert "Rollback of elastic#98586 (elastic#98805)"

This reverts commit e370194.

* Skip updating source when missing synthetic mode

* Update docs/changelog/98808.yaml

* Skip matching assert in MapperService too

* Refine the assert

* Extend versions before 8.6, when TS had no synthetic source

* Add source field mapping for non-synthetic TSDB

* Delete 98586.yaml

Duplicate changelog

* Add comment to TSDB_NO_SYNTHETIC mapping

* Spotless fix

* Add yaml test

* Fix version skip in yaml test
@kkrik-es kkrik-es added :Analytics/Aggregations Aggregations >enhancement backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) test-full-bwc Trigger full BWC version matrix tests labels Aug 25, 2023
@kkrik-es kkrik-es added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) v8.10.1 and removed v8.10.1 labels Aug 25, 2023
@elasticsearchmachine elasticsearchmachine merged commit 7bb301c into elastic:8.10 Aug 25, 2023
@kkrik-es kkrik-es deleted the backport/8.10/pr-98808 branch August 25, 2023 09:15
@JVerwolf JVerwolf added v8.10.0 and removed v8.10.1 labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) test-full-bwc Trigger full BWC version matrix tests v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants