Add the ability to return the score of the named queries #94564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new rest parameter called `rest_include_named_queries_score` that when set, includes the score of the named queries that matched the document. Note that with this change, the score of named queries is always returned when using the transport client. The rest level has the ability to set the format of the matched_queries section for BWC (kept as is by default). Closes elastic#65563
jimczi
added
>feature
:Search/Search
Contributor
|
Documentation preview: |
elasticsearchmachine
added
the
external-contributor
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
jimczi
removed
the
external-contributor
romseygeek
approved these changes
Mar 21, 2023
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
One query about the parameter name, but LGTM otherwise. It's a bit of a shame that this precludes us using Matches to build these for the moment, but that wasn't going to happen any time soon anyway.
|
I believe this may have introduced a performance regression in certain edge cases: #120130. Would like some thoughts with people more familiar with these code paths. |
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 14, 2025
This PR resolves a regression introduced in elastic#94564 by ensuring that the approximation is used when advancing matched query clauses. Utilizing the two-phase iterator to validate matches guarantees that we do not attempt to find the next document fulfilling the two-phase criteria beyond the current document. This fix prevents scenarios where matching a document in the second phase significantly increases query complexity, especially in cases involving restrictive second-pass filters. Closes elastic#120130
jimczi
added a commit
that referenced
this pull request
Jan 14, 2025
This PR resolves a regression introduced in #94564 by ensuring that the approximation is used when advancing matched query clauses. Utilizing the two-phase iterator to validate matches guarantees that we do not attempt to find the next document fulfilling the two-phase criteria beyond the current document. This fix prevents scenarios where matching a document in the second phase significantly increases query complexity, especially in cases involving restrictive second-pass filters. Closes #120130
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 14, 2025
This PR resolves a regression introduced in elastic#94564 by ensuring that the approximation is used when advancing matched query clauses. Utilizing the two-phase iterator to validate matches guarantees that we do not attempt to find the next document fulfilling the two-phase criteria beyond the current document. This fix prevents scenarios where matching a document in the second phase significantly increases query complexity, especially in cases involving restrictive second-pass filters. Closes elastic#120130
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 14, 2025
This PR resolves a regression introduced in elastic#94564 by ensuring that the approximation is used when advancing matched query clauses. Utilizing the two-phase iterator to validate matches guarantees that we do not attempt to find the next document fulfilling the two-phase criteria beyond the current document. This fix prevents scenarios where matching a document in the second phase significantly increases query complexity, especially in cases involving restrictive second-pass filters. Closes elastic#120130
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 14, 2025
This PR resolves a regression introduced in elastic#94564 by ensuring that the approximation is used when advancing matched query clauses. Utilizing the two-phase iterator to validate matches guarantees that we do not attempt to find the next document fulfilling the two-phase criteria beyond the current document. This fix prevents scenarios where matching a document in the second phase significantly increases query complexity, especially in cases involving restrictive second-pass filters. Closes elastic#120130
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 14, 2025
This PR resolves a regression introduced in #94564 by ensuring that the approximation is used when advancing matched query clauses. Utilizing the two-phase iterator to validate matches guarantees that we do not attempt to find the next document fulfilling the two-phase criteria beyond the current document. This fix prevents scenarios where matching a document in the second phase significantly increases query complexity, especially in cases involving restrictive second-pass filters. Closes #120130
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 14, 2025
This PR resolves a regression introduced in #94564 by ensuring that the approximation is used when advancing matched query clauses. Utilizing the two-phase iterator to validate matches guarantees that we do not attempt to find the next document fulfilling the two-phase criteria beyond the current document. This fix prevents scenarios where matching a document in the second phase significantly increases query complexity, especially in cases involving restrictive second-pass filters. Closes #120130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new search rest parameter called
rest_include_named_queries_scorewhich when set, includes the score of the named queries that matched the document. Note that with this change, the score of named queries is always returned when using the transport client. The rest level has the ability to set the format of thematched_queriessection in the response for BWC (as a map with the associated score when the new mode is activated).Closes #29606