Simplify InboundPipeline and make it more obviously correct #91350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intermediary fragments list is redundant as it duplicates tracking of fragments in the inbound aggregator. By passing fragments directly down the pipeline instead of putting them into the list we can avoid having to check for end of message in the inbound pipeline entirely. Also, the logic becomes of obviously safe and correct since we save the unintuitive step of releasing the fragments list in a final loop.
original-brownbear
added
:Distributed Coordination/Network
original-brownbear
requested review from
Tim-Brooks,
henningandersen and
DaveCTurner
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
v9.1.0
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-obsolete (Team:Distributed (Obsolete)) |
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted as the hopefully not so controversial change from #80656 which does not alter the ref counting but saves complexity and cycles.
The intermediary fragments list is redundant as it duplicates tracking of fragments in the inbound aggregator. By passing fragments directly down the pipeline instead of putting them into the list we can avoid having to check for end of message in the inbound pipeline entirely.
Also, the logic becomes more obviously safe and correct since we save the unintuitive step of releasing the fragments list in a final loop.