Safely fail queued writes in Netty4WriteThrottlingHandler #90978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the hook to fail queued writes to disconnect and channel close, as is done by `SslHandler`. Maybe this explains random leaks on unstable connections.
original-brownbear
added
>non-issue
:Distributed/Network
|
Pinging @elastic/es-distributed (Team:Distributed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the hook to fail queued writes to disconnect and channel close, as is done by
SslHandler. Maybe this explains random leaks on unstable connections, though to be honest I have no proof of this yet.It seems like if anything this change makes it so some memory is released earlier which is always a plus even if it doesn't catch the leak. Also, it rules out one route to leaks.