Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output a consistent format when generating error json #90529

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Output a consistent format when generating error json #90529

wants to merge 25 commits into from

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Sep 29, 2022 •
edited
Loading

Now, error fields will always have 'type' and 'reason' fields, and the information in those fields is the same regardless of whether the output is detailed or not

This fixes #89387

@thecoop
Output a consistent format when generating error json
b0c0682 
Now, error fields will always have 'type' and 'reason' fields, and the information in those fields is the same regardless of whether the output is detailed or not
@thecoop thecoop added >bug :Core/Infra/REST API REST infrastructure and utilities labels Sep 29, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v8.6.0 labels Sep 29, 2022
@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've created a changelog YAML for you.

@thecoop
Copy link
Member Author

thecoop commented Sep 29, 2022

Note this does have some BwC concerns, as this changes the output format when not detailed, but from #89387 we consider the current behaviour a bug

@thecoop thecoop marked this pull request as draft September 29, 2022 15:56
@thecoop thecoop marked this pull request as ready for review September 30, 2022 10:17
@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've updated the changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've updated the changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've updated the changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

@ChrisHegarty
Copy link
Contributor

This PR is marked as a "breaking" change. Is it really a breaking change?

@gmarouli gmarouli added v8.9.0 and removed v8.8.0 labels Apr 26, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've updated the changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

@quux00 quux00 added v8.11.0 and removed v8.10.0 labels Aug 16, 2023
@mattc58 mattc58 added v8.12.0 and removed v8.11.0 labels Oct 4, 2023
@thecoop thecoop requested a review from a team October 10, 2024 15:22
@thecoop
Copy link
Member Author

thecoop commented Oct 10, 2024

@elasticmachine update branch

@thecoop thecoop mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty requested changes

@grcevski grcevski grcevski approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
>breaking >bug :Core/Infra/REST API REST infrastructure and utilities Team:Core/Infra Meta label for core/infra team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solidify & document guarantees about structure of error responses