Skip to content

Conversation

@DaveCTurner
Copy link
Contributor

Adds to the docs a note that the 100mb default for http.max_content_length is the recommended maximum, along with suggestions for what to do when hitting this limit.

Adds to the docs a note that the `100mb` default for
`http.max_content_length` is the recommended maximum, along with
suggestions for what to do when hitting this limit.
@DaveCTurner DaveCTurner added >docs General docs changes :Distributed Coordination/Network Http and internode communication implementations v7.17.7 v8.6.0 labels Sep 29, 2022
@github-actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team labels Sep 29, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment on lines -115 to -116
When using the HTTP API, make sure that the client does not send HTTP chunks,
as this will slow things down.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand the slow down of this and assume it is on purpose that you removed it. But curious if you found out why this is there (I see Clinton added it in 2013).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I'm also not sure where this came from and removing it was deliberate. Sending requests in chunks should actually be a little faster because it parallelises the accumulation of items in the bulk request with the sending of the request to ES. Even if it was slower in 2013 I don't think it's true today, or at least if it is then we should fix it rather than just documenting it.

@DaveCTurner DaveCTurner merged commit c95fb2f into elastic:main Sep 29, 2022
@DaveCTurner DaveCTurner deleted the 2022-09-29-max_content_length-details branch September 29, 2022 15:07
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
7.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 90500

DaveCTurner added a commit that referenced this pull request Sep 29, 2022
Adds to the docs a note that the `100mb` default for
`http.max_content_length` is the recommended maximum, along with
suggestions for what to do when hitting this limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Network Http and internode communication implementations >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.17.7 v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants