-
Notifications
You must be signed in to change notification settings - Fork 25.7k
More opinionated docs about http.max_content_length #90500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More opinionated docs about http.max_content_length #90500
Conversation
Adds to the docs a note that the `100mb` default for `http.max_content_length` is the recommended maximum, along with suggestions for what to do when hitting this limit.
|
Documentation preview: |
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
| When using the HTTP API, make sure that the client does not send HTTP chunks, | ||
| as this will slow things down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I understand the slow down of this and assume it is on purpose that you removed it. But curious if you found out why this is there (I see Clinton added it in 2013).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I'm also not sure where this came from and removing it was deliberate. Sending requests in chunks should actually be a little faster because it parallelises the accumulation of items in the bulk request with the sending of the request to ES. Even if it was slower in 2013 I don't think it's true today, or at least if it is then we should fix it rather than just documenting it.
💔 Backport failed
You can use sqren/backport to manually backport by running |
Adds to the docs a note that the `100mb` default for `http.max_content_length` is the recommended maximum, along with suggestions for what to do when hitting this limit.
Adds to the docs a note that the
100mbdefault forhttp.max_content_lengthis the recommended maximum, along with suggestions for what to do when hitting this limit.