Skip to content

Fix slow assertion running in production in RoutingNodes #88951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

original-brownbear
Copy link
Contributor

This needs to be in a separate method, it's currently running in production
and uses significant CPU time.

Broken in #88794

This needs to be in a separate method, it's currently running in production
and uses significant CPU time.

Broken in elastic#88794
@original-brownbear original-brownbear added >non-issue :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v8.5.0 labels Jul 29, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jul 29, 2022
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Contributor Author

Thanks David!

Merging despite the failures since those are obvious Jenkins issue unrelated to the changes here.

@original-brownbear original-brownbear merged commit 713657f into elastic:main Jul 29, 2022
@original-brownbear original-brownbear deleted the fix-accidental-assert-hot-path branch July 29, 2022 20:37
@original-brownbear original-brownbear restored the fix-accidental-assert-hot-path branch April 18, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants