[TSDB] Exclude index.block.write setting when creating rollup index
#88812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csoulios
added
>non-issue
:StorageEngine/Rollup
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
nik9000
approved these changes
Jul 26, 2022
csoulios
changed the title
index.block.write index setting when creating rollup indexindex.block.write setting when creating rollup index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #88565 modified the rollup action so that it copies all index settings from the source to the rollup index.
However, the rollup action expilitly requires that the source index has the
index.block.write: true.Since the rollup index must be writeable when it is created, this PR excludes the
index.block.writeindex setting when creating the rollup index.The
index.block.writeindex setting is explictly set totrueat the end of the rollup action (step 4).