Fix queued snapshot assignments after partial snapshot fails due to delete #88470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elete We can't just assume that snapshot after snapshot is assigned right, we must re-compute the right node or whether or not the shard even exists still. closes elastic#86724
original-brownbear
added
>bug
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @original-brownbear, I've created a changelog YAML for you. |
|
Jenkins run elasticsearch-ci/part-2 |
| final SnapshotsInProgress.ShardSnapshotStatus shardSnapshotStatus = startedSnapshot.shards().get(routingShardId); | ||
| assertThat(shardSnapshotStatus.state(), is(SnapshotsInProgress.ShardState.INIT)); | ||
| assertThat(shardSnapshotStatus.nodeId(), is(dataNodeId)); | ||
| assertThat(shardSnapshotStatus.state(), is(SnapshotsInProgress.ShardState.MISSING)); |
There was a problem hiding this comment.
This was broken before, the shard isn't assigned so it must not move to INIT
=> since there's no other shards the snapshot must complete right away as well.
| updatedState.generation(), | ||
| entry.shardId(repoShardId) | ||
| ); | ||
| startShardSnapshot(repoShardId, updatedState.generation()); |
There was a problem hiding this comment.
No big change here really, just extracted the code that re-computes where to run the snapshot since we don't need to do the isQueued check twice and used it here.
|
Thanks Tanguy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't just assume that snapshot after snapshot is assigned right,
we must re-compute the right node or whether or not the shard even
exists still.
closes #86724