Skip to content

Run gradle integration tests with configuration cache enabled by default #88148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2022

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Jun 29, 2022

This changes AbstractGradleFuncTest to run with configuration cache enabled by default. That gives us better test coverage on how our build logic works with configuration cache enabled and makes it explicit which parts are not yet working.
We fixed some minor configuration cache related issues in our code

@breskeby breskeby self-assigned this Jun 29, 2022
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team labels Jun 29, 2022
@breskeby breskeby force-pushed the improve-cc-test-coverage branch from 96a2f88 to 2118ac1 Compare June 29, 2022 07:19
@breskeby breskeby changed the title Test with configuration cache enabled by default Run gradle integration tests with configuration cache enabled by default Jun 29, 2022
@breskeby breskeby marked this pull request as ready for review June 29, 2022 16:30
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby force-pushed the improve-cc-test-coverage branch from 0565f49 to 78dbdeb Compare June 29, 2022 17:36
@breskeby
Copy link
Contributor Author

This changes AbstractGradleFuncTest to run with configuration cache enabled by default. That gives us better test coverage on how our build logic works with configuration cache enabled and makes it explicit which parts are not yet working.
We fixed some minor configuration cache related issues in our code.

@breskeby breskeby merged commit ca4f3a3 into elastic:master Jun 30, 2022
@breskeby breskeby deleted the improve-cc-test-coverage branch June 30, 2022 09:08
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jul 18, 2022
…ult (elastic#88148)

This changes AbstractGradleFuncTest to run with configuration cache enabled by default. That gives us better test coverage on how our build logic works with configuration cache enabled and makes it explicit which parts are not yet working.
We fixed some minor configuration cache related issues in our code.
# Conflicts:
#	build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/BuildPluginFuncTest.groovy
#	build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/distibution/ElasticsearchDistributionPluginFuncTest.groovy
#	build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTaskFuncTest.groovy
#	build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/test/rest/YamlRestCompatTestPluginFuncTest.groovy
#	build-tools/src/integTest/groovy/org/elasticsearch/gradle/plugin/PluginBuildPluginFuncTest.groovy
breskeby added a commit that referenced this pull request Jul 18, 2022
…by default (#88148) (#88578)

Backports the following commits to 7.17:
 - Run gradle integration tests with configuration cache enabled by default (#88148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants