-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Replace ilm/slm with their full names #88060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This also fixes some doc typos "reponse" -> "response".
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-data-management (Team:Data Management) |
Failure tracked already in #88063 |
@elasticmachine update branch |
@@ -61,14 +61,14 @@ The reponse will look like this: | |||
// end::cloud[] | |||
|
|||
// tag::self-managed[] | |||
<<ilm-start, Start ILM>>: | |||
<<ilm-start, Start Index Lifecycle Management>>: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious why are we specifically typing here Index Lifecycle Management
and not {ilm}
like we do in the start-slm
doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular reason. I think we can't link to these { }
macros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, that's why in the slm it is <<ilm-start, Start>> {slm}
. I would suggest to do the same here so we are consistently using the macros.
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small suggestion about using a macro.
docs/reference/tab-widgets/troubleshooting/data/start-ilm.asciidoc
Outdated
Show resolved
Hide resolved
💔 Backport failedThe backport operation could not be completed due to the following error:
You can use sqren/backport to manually backport by running |
(cherry picked from commit 3e1242b) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This also fixes some doc typos "reponse" -> "response".