Skip to content

More REST tests for avg/max/min/sum_bucket aggs #88027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jun 24, 2022

Adds REST layer tests for some sneaky cases in the the avg_bucket,
max_bucket, min_bucket, and sum_bucket pipeline aggregations.
This gives us forwards and backwards compatibility tests for these
aggs as well as mixed version cluster tests for these aggs.

Relates to #26220

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations v8.4.0 labels Jun 24, 2022
@nik9000 nik9000 requested a review from csoulios June 24, 2022 17:36
Adds REST layer tests for some sneaky cases in the the `avg_bucket`,
`max_bucket`, `min_bucket`, and `sum_bucket` pipeline aggregations.
This gives us forwards and backwards compatibility tests for these
aggs as well as mixed version cluster tests for these aggs.

Relates to elastic#26220
@nik9000 nik9000 marked this pull request as ready for review June 24, 2022 17:52
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Jun 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

Copy link
Contributor

@csoulios csoulios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for iterating on this

@nik9000 nik9000 merged commit d88dfb1 into elastic:master Jun 27, 2022
@nik9000
Copy link
Member Author

nik9000 commented Jun 27, 2022

Happy to do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Clients Meta label for clients team >test Issues or PRs that are addressing/adding tests v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants