[ML] Rebalance should not notify listener before update is applied #88012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are rebalancing trained model assignments, we eventually update cluster state with the new metadata. We only want to notify the listener after we have applied the cluster state update. This commit fixes a bug where we could notify before the update was actually applied resulting in NPE when writing the response of the `CreateTrainedModelAssignmentAction`. This is a fix following the work done in elastic#87366.
|
Pinging @elastic/ml-core (Team:ML) |
benwtrent
approved these changes
Jun 24, 2022
Comment on lines
+414
to
+416
| if (isUpdated) { | ||
| listener.onResponse(TrainedModelAssignmentMetadata.fromState(newState)); | ||
| } |
There was a problem hiding this comment.
Ah, yeah, this would happen because of the return currentState in execute kicking off another rebalancing.
There was a problem hiding this comment.
Yeah, you were right there was something off there!
dimitris-athanasiou
deleted the
rebalance-should-not-notify-listener-before-update-is-applied
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are rebalancing trained model assignments, we eventually
update cluster state with the new metadata. We only want to
notify the listener after we have applied the cluster state update.
This commit fixes a bug where we could notify before the update
was actually applied resulting in NPE when writing the response
of the
CreateTrainedModelAssignmentAction.This is a fix following the work done in #87366.