-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Move the ingest attachment processor to the default distribution #87989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the ingest attachment processor to the default distribution #87989
Conversation
The ingest attachment processor is currently available as a plugin. This commit moves the processor to the default distribution so it is always available.
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @rjernst, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming the docs issues are cleared up, thanks Ryan
@lcawl I think I addressed the issues you found, can you take another look? |
@elasticmachine run elasticsearch-ci/docs rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some minor doc edits, tested locally, and both the plugins and elasticsearch guides LGTM
f0d4c66
to
b25a244
Compare
I don't think we can do this (at least not easily). The ingest attachment plugin isn't FIPS compatible, which it can't be included in the default distribution (because the default distribution is supposed to be FIPS compatible). |
The reason for the FIPS incompatibility was a transitive dependency on bouncycastle. However, that dependency is now removed (see #88031). |
The ingest attachment processor is currently available as a plugin. This
commit moves the processor to the default distribution so it is always
available.