Skip to content

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Jun 23, 2022

The ingest attachment processor is currently available as a plugin. This
commit moves the processor to the default distribution so it is always
available.

The ingest attachment processor is currently available as a plugin. This
commit moves the processor to the default distribution so it is always
available.
@rjernst rjernst added >enhancement :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.4.0 labels Jun 23, 2022
@rjernst rjernst requested review from dakrone and lcawl June 23, 2022 19:55
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 23, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @rjernst, I've created a changelog YAML for you.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the docs issues are cleared up, thanks Ryan

@rjernst
Copy link
Member Author

rjernst commented Jun 24, 2022

@lcawl I think I addressed the issues you found, can you take another look?

@lcawl
Copy link
Contributor

lcawl commented Jun 27, 2022

@elasticmachine run elasticsearch-ci/docs rebuild

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some minor doc edits, tested locally, and both the plugins and elasticsearch guides LGTM

@rjernst rjernst added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 28, 2022
@rjernst rjernst force-pushed the attachment/component branch from f0d4c66 to b25a244 Compare June 28, 2022 05:05
@tvernum
Copy link
Contributor

tvernum commented Jun 28, 2022

I don't think we can do this (at least not easily). The ingest attachment plugin isn't FIPS compatible, which it can't be included in the default distribution (because the default distribution is supposed to be FIPS compatible).

@rjernst
Copy link
Member Author

rjernst commented Jun 28, 2022

The reason for the FIPS incompatibility was a transitive dependency on bouncycastle. However, that dependency is now removed (see #88031).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants