Skip to content

Remove dead code from TokenService #87739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 20, 2022

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Jun 16, 2022

This PR removes code marked as unused or redundant in TokenService.
More involved code removal to come.

Relates #87729

@n1v0lg n1v0lg added >refactoring :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team v8.4.0 labels Jun 16, 2022
@n1v0lg n1v0lg self-assigned this Jun 16, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@n1v0lg n1v0lg requested a review from tvernum June 16, 2022 13:54
Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Jun 20, 2022

@elasticmachine update branch

@n1v0lg n1v0lg merged commit 3d9fca8 into elastic:master Jun 20, 2022
@n1v0lg n1v0lg deleted the refactor/remove-dead-code-token-service branch June 20, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>refactoring :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants