Complete listener on rejection in FollowersChecker #86259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#83576 we made it so that forking off the transport thread when handling a follower check might be rejected if we're shutting down. In that case we don't pass the rejection exception back out and instead rely on the transport connection's close to notify the caller. We also manipulate the transport channel directly which misses some exception cases. This commit adjusts the implementation to fix these things.
DaveCTurner
added
>non-issue
:Distributed Coordination/Cluster Coordination
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
|
henningandersen
approved these changes
May 6, 2022
DaveCTurner
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #83576 we made it so that forking off the transport thread when
handling a follower check might be rejected if we're shutting down. In
that case we don't pass the rejection exception back out and instead
rely on the transport connection's close to notify the caller. We also
manipulate the transport channel directly which misses some exception
cases. This commit adjusts the implementation to fix these things.