Skip to content

Remove SnapshotClient from HLRC #85845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Apr 12, 2022

This removes the SnapshotClient from the high level rest client, rewriting the tests to use the
low-level client instead.

Relates to #83423

This removes the `SnapshotClient` from the high level rest client, rewriting the tests to use the
low-level client instead.

Relates to elastic#83423
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@dakrone dakrone mentioned this pull request Apr 12, 2022
66 tasks
Copy link
Contributor

@joegallo joegallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, your call whether my ✅ is good enough given my commits here. And also if you don't like any of my commits, we can totally undo them.

@dakrone
Copy link
Member Author

dakrone commented Apr 14, 2022

@elasticmachine update branch

@dakrone dakrone added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 14, 2022
@elasticsearchmachine elasticsearchmachine merged commit 6d6c7d5 into elastic:master Apr 14, 2022
@dakrone dakrone deleted the hlrc-remove-snapshots-client branch April 14, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue Team:Clients Meta label for clients team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants