Skip to content

Remove hppc from tcp transport #85843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Apr 12, 2022

The TcpTransport uses an hppc int set when falling back to
determine if there is a unique port bound. Since the expectation is this
is a single value, the map should be very small. This commit switches to
using a HashSet.

relates #84735

The TcpTransport uses an hppc int set when falling back to
determine if there is a unique port bound. Since the expectation is this
is a single value, the map should be very small. This commit switches to
using a HashSet.

relates elastic#84735
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Apr 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst rjernst requested a review from Tim-Brooks April 12, 2022 20:02
@rjernst rjernst mentioned this pull request Apr 12, 2022
43 tasks
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit c8ccc3d into elastic:master Apr 13, 2022
@rjernst rjernst deleted the hppc/transport_ports branch April 13, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Transport API Transport client API >refactoring Team:Core/Infra Meta label for core/infra team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants