Skip to content

[DOCS] Add default value for destructive_requires_name #85591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

Leaf-Lin
Copy link
Contributor

@Leaf-Lin Leaf-Lin commented Apr 1, 2022

As per #66908, the setting now defaults to True, but it's not shown in the doc. Can we please have the doc updated?

As per #66908, the setting now defaults to `True`, but it's not shown in the doc.  Can we please have the doc updated?
@Leaf-Lin Leaf-Lin added >docs General docs changes Team:Docs Meta label for docs team labels Apr 1, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@williamrandolph williamrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

@lockewritesdocs lockewritesdocs merged commit 65b05f8 into main Aug 25, 2022
@lockewritesdocs lockewritesdocs deleted the Leaf-Lin-destructive_requires_name-true branch August 25, 2022 12:44
@lockewritesdocs lockewritesdocs changed the title Add default value for destructive_requires_name [DOCS] Add default value for destructive_requires_name Aug 25, 2022
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.3
8.4

Leaf-Lin added a commit to Leaf-Lin/elasticsearch that referenced this pull request Aug 25, 2022
As per elastic#66908, the setting now defaults to `True`, but it's not shown in the doc.  Can we please have the doc updated?
Leaf-Lin added a commit to Leaf-Lin/elasticsearch that referenced this pull request Aug 25, 2022
As per elastic#66908, the setting now defaults to `True`, but it's not shown in the doc.  Can we please have the doc updated?
elasticsearchmachine pushed a commit that referenced this pull request Aug 25, 2022
As per #66908, the setting now defaults to `True`, but it's not shown in the doc.  Can we please have the doc updated?
elasticsearchmachine pushed a commit that referenced this pull request Aug 25, 2022
As per #66908, the setting now defaults to `True`, but it's not shown in the doc.  Can we please have the doc updated?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes Team:Docs Meta label for docs team v8.3.4 v8.4.1 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants