-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Wait longer for CCR auto-follow stats to appear in monitoring index #85278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Mar 23, 2022
fcofdez
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks both |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 23, 2022
…lastic#85278) The test `AutoFollowIT.testAutoFollowPatterns()` failed multiple times when waiting for CCR's auto-follow stats to be collected and indexed in the `.monitoring-es-*` index. This is possibly because monitoring data are collected every 10 seconds and some of them can take more time to be collected, exceeding the 30s timeout in the test. This pull request re-uses the `assertLongBusy()` so that the test will wait more time for the data to show up and in case the data are not here it will prints out the current CCR's auto-follow stats for debugging purpose. Closes elastic#84403
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 23, 2022
…lastic#85278) The test `AutoFollowIT.testAutoFollowPatterns()` failed multiple times when waiting for CCR's auto-follow stats to be collected and indexed in the `.monitoring-es-*` index. This is possibly because monitoring data are collected every 10 seconds and some of them can take more time to be collected, exceeding the 30s timeout in the test. This pull request re-uses the `assertLongBusy()` so that the test will wait more time for the data to show up and in case the data are not here it will prints out the current CCR's auto-follow stats for debugging purpose. Closes elastic#84403
💔 Backport failed
You can use sqren/backport to manually backport by running |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 23, 2022
…lastic#85278) The test `AutoFollowIT.testAutoFollowPatterns()` failed multiple times when waiting for CCR's auto-follow stats to be collected and indexed in the `.monitoring-es-*` index. This is possibly because monitoring data are collected every 10 seconds and some of them can take more time to be collected, exceeding the 30s timeout in the test. This pull request re-uses the `assertLongBusy()` so that the test will wait more time for the data to show up and in case the data are not here it will prints out the current CCR's auto-follow stats for debugging purpose. Closes elastic#84403
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 23, 2022
…85278) (#85285) The test `AutoFollowIT.testAutoFollowPatterns()` failed multiple times when waiting for CCR's auto-follow stats to be collected and indexed in the `.monitoring-es-*` index. This is possibly because monitoring data are collected every 10 seconds and some of them can take more time to be collected, exceeding the 30s timeout in the test. This pull request re-uses the `assertLongBusy()` so that the test will wait more time for the data to show up and in case the data are not here it will prints out the current CCR's auto-follow stats for debugging purpose. Closes #84403
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 23, 2022
…85278) (#85288) The test `AutoFollowIT.testAutoFollowPatterns()` failed multiple times when waiting for CCR's auto-follow stats to be collected and indexed in the `.monitoring-es-*` index. This is possibly because monitoring data are collected every 10 seconds and some of them can take more time to be collected, exceeding the 30s timeout in the test. This pull request re-uses the `assertLongBusy()` so that the test will wait more time for the data to show up and in case the data are not here it will prints out the current CCR's auto-follow stats for debugging purpose. Closes #84403
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Apr 25, 2022
Now elastic#84467 has been backported to 7.17 (elastic#85514) the recent failures are always due to monitoring docs not being indexed in monitoring indices within 30s. Similarly to what has been done for `AutoFollowIT.testAutoFollowPatterns()` in elastic#85278 which reduced the number of failures, we can wait longer in `FollowIndexSecurityIT.testAutoFollowPatterns()` for monitoring docs to be indexed. Closes elastic#84888
tlrx
added a commit
that referenced
this pull request
Apr 26, 2022
…86140) Now #84467 has been backported to 7.17 (#85514) the recent failures are always due to monitoring docs not being indexed in monitoring indices within 30s. Similarly to what has been done for `AutoFollowIT.testAutoFollowPatterns()` in #85278 which reduced the number of failures, we can wait longer in `FollowIndexSecurityIT.testAutoFollowPatterns()` for monitoring docs to be indexed. Closes #84888
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Apr 26, 2022
…lastic#86140) Now elastic#84467 has been backported to 7.17 (elastic#85514) the recent failures are always due to monitoring docs not being indexed in monitoring indices within 30s. Similarly to what has been done for `AutoFollowIT.testAutoFollowPatterns()` in elastic#85278 which reduced the number of failures, we can wait longer in `FollowIndexSecurityIT.testAutoFollowPatterns()` for monitoring docs to be indexed. Closes elastic#84888
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Apr 26, 2022
…lastic#86140) Now elastic#84467 has been backported to 7.17 (elastic#85514) the recent failures are always due to monitoring docs not being indexed in monitoring indices within 30s. Similarly to what has been done for `AutoFollowIT.testAutoFollowPatterns()` in elastic#85278 which reduced the number of failures, we can wait longer in `FollowIndexSecurityIT.testAutoFollowPatterns()` for monitoring docs to be indexed. Closes elastic#84888
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 26, 2022
…86140) (#86172) Now #84467 has been backported to 7.17 (#85514) the recent failures are always due to monitoring docs not being indexed in monitoring indices within 30s. Similarly to what has been done for `AutoFollowIT.testAutoFollowPatterns()` in #85278 which reduced the number of failures, we can wait longer in `FollowIndexSecurityIT.testAutoFollowPatterns()` for monitoring docs to be indexed. Closes #84888
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 26, 2022
…86140) (#86174) Now #84467 has been backported to 7.17 (#85514) the recent failures are always due to monitoring docs not being indexed in monitoring indices within 30s. Similarly to what has been done for `AutoFollowIT.testAutoFollowPatterns()` in #85278 which reduced the number of failures, we can wait longer in `FollowIndexSecurityIT.testAutoFollowPatterns()` for monitoring docs to be indexed. Closes #84888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Distributed Indexing/CCR
Issues around the Cross Cluster State Replication features
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
>test
Issues or PRs that are addressing/adding tests
v7.17.2
v8.1.2
v8.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
AutoFollowIT.testAutoFollowPatterns()
failed multiple times when waiting for CCR's auto-follow stats to be collected and indexed in the.monitoring-es-*
index. This is possibly because monitoring data are collected every 10 seconds and some of them can take more time to be collected, exceeding the 30s timeout in the test.This pull request re-uses the
assertLongBusy()
so that the test will wait more time for the data to show up and in case the data are not here it will prints out the current CCR's auto-follow stats for debugging purpose.Closes #84403