Skip to content

[ML] remove use of hppc collections from NLP tokenization #84815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benwtrent
Copy link
Member

Replaces the use of hppc collections with that of native java collections.

The performance difference is near 0.

@benwtrent benwtrent added >non-issue :ml Machine learning v8.2.0 labels Mar 9, 2022
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Mar 9, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 947a342 into elastic:master Mar 9, 2022
@benwtrent benwtrent deleted the feature/remove-unnecessary-hppc-code-ml branch March 9, 2022 15:32
@rjernst rjernst mentioned this pull request Mar 9, 2022
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants