Remove some inner classes from MasterService #84448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the `MasterService` has inner classes `TaskInputs`, `TaskOutputs` and `BatchExecutionResult` that collect up various data needed for the cluster state update computation. In fact they're not necessary: we already have everything we need at the top level except the new `ClusterState`, which we can return directly.
DaveCTurner
added
>refactoring
:Distributed Coordination/Cluster Coordination
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
@elasticmachine please run elasticsearch-ci/part-1 |
idegtiarenko
reviewed
Mar 1, 2022
| threadPool | ||
| ) | ||
| ) | ||
| .collect(Collectors.toList()) |
There was a problem hiding this comment.
I believe this was moved from createAckListener, however is it possible to update it to use immutable list?
Suggested change
| .collect(Collectors.toList()) | |
| .toList() |
There was a problem hiding this comment.
Good point, yes.
idegtiarenko
approved these changes
Mar 1, 2022
|
@elasticmachine please run elasticsearch-ci/rest-compatibility |
|
#84484 will fix the unrelated failure; @elasticmachine please run elasticsearch-ci/part-1 |
DaveCTurner
deleted the
2022-02-28-master-service-remove-intermediate-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the
MasterServicehas inner classesTaskInputs,TaskOutputsand
BatchExecutionResultthat collect up various data needed for thecluster state update computation. In fact they're not necessary: we
already have everything we need at the top level except the new
ClusterState, which we can return directly.