Drop bogus markAsSystemContext call in CCR #84409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the `ShardFollowTasksExecutor` enters system context before renewing a retention lease, but then makes the remote call using a client which replaces the thread context with a non-system one again. This commit removes this no-op code to clarify the security model in this area. Relates elastic#61308, elastic#84006, elastic#84156
DaveCTurner
added
>non-issue
:Distributed Indexing/CCR
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Marking this as |
|
The test is now fixed and unmuted #84467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the
ShardFollowTasksExecutorenters system context beforerenewing a retention lease, but then makes the remote call using a
client which replaces the thread context with a non-system one again.
This commit removes this no-op code to clarify the security model in
this area.
Relates #61308, #84006, #84156