Skip to content

[8.0] Always re-run Feature migrations which have encountered errors (#83918) #84138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Feb 17, 2022

Backports the following commits to 8.0:

@gwbrown gwbrown added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport labels Feb 17, 2022
@cla-checker-service
Copy link

cla-checker-service bot commented Feb 22, 2022

💚 CLA has been signed

…ic#83918)

This PR addressed the behavior described in elastic#83917, in which Feature migrations
which have encountered errors are not re-run in some cases. As of this PR, Features
which have encountered errors during migration are treated the same as Features 
requiring migration.

This PR also adds a test which artificially replicates elastic#83917.
@gwbrown gwbrown force-pushed the backport/8.0/pr-83918 branch from 3589c5a to b7479c4 Compare February 22, 2022 18:42
@gwbrown
Copy link
Contributor Author

gwbrown commented Feb 22, 2022

CLA business was due to forgetting to configure my git author name & email on my new laptop. Hence the force push.

@elasticsearchmachine elasticsearchmachine merged commit 90dc01a into elastic:8.0 Feb 22, 2022
@gwbrown gwbrown deleted the backport/8.0/pr-83918 branch February 22, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants