Add Maps.newLinkedHashMapWithExpectedSize #84054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
force-pushed
the
pre-size-linkedhashmap
branch
from
e4286b3 to
5705b66
Compare
|
@elasticmachine update branch |
| * @param <V> the value type | ||
| * @return a new pre-sized {@link LinkedHashMap} | ||
| */ | ||
| public static <K, V> Map<K, V> newLinkedHashMapWithExpectedSize(int expectedSize) { |
There was a problem hiding this comment.
I would recommend to keep the return type as LinkedHashMap. No need to hide implementation as it is already in the name. This will also avoid the type casts in some use cases
| keys.put("foo.date_histogram", 123L); | ||
|
|
||
| char[] charArray = new char[IndexWriter.MAX_TERM_LENGTH]; | ||
| Arrays.fill(charArray, 'a'); | ||
| keys.put("bar.terms", new String(charArray)); | ||
| keys.put("abc.histogram", 1.9); | ||
| keys = shuffleMap(keys, Collections.emptySet()); | ||
| keys = shuffleMap((LinkedHashMap<String, Object>) keys, Collections.emptySet()); |
There was a problem hiding this comment.
This and above type cast could be avoided. See my other comment
idegtiarenko
approved these changes
Feb 17, 2022
x-pack/plugin/rollup/src/test/java/org/elasticsearch/xpack/rollup/job/IndexerUtilsTests.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/part-1 |
|
Thanks Ievgen! |
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 23, 2022
* Add Maps.newLinkedHashMapWithExpectedSize * Return LinkedHashMap * Don't cast LinkedHashMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.