-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Fixing random_sampler tests #83549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benwtrent
merged 2 commits into
elastic:master
from
benwtrent:feature/sampling-test-fixes
Feb 7, 2022
Merged
Fixing random_sampler tests #83549
benwtrent
merged 2 commits into
elastic:master
from
benwtrent:feature/sampling-test-fixes
Feb 7, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes smoke tests my enabling the random_sampler agg Fixes flakey sampler test closes elastic#83523 closes elastic#83357
Pinging @elastic/es-analytics-geo (Team:Analytics) |
kirakoki
approved these changes
Feb 5, 2022
dimitris-athanasiou
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 Backport failed
You can use sqren/backport to manually backport by running |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 7, 2022
Fixes smoke tests my enabling the random_sampler agg Fixes flakey sampler test closes elastic#83523 closes elastic#83357
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2022
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 7, 2022
* upstream/master: [DOCS] Switch xrefs to external links (elastic#83590) [DOCS] 'features' flag added in elastic#83083 (elastic#83452) Rename ChangePolicyforIndexIT to ChangePolicyForIndexIT (elastic#83569) Fixing random_sampler tests (elastic#83549) Upgrade Checkstyle to 9.3 (elastic#83314) Make improvements to the release notes generator (elastic#83525) Cleanup DataTierAllocationDecider (elastic#83572) Upgrade jANSI dependency to 2.4.0 (elastic#83566) Speed up Name Collision Check in Metadata.Builder (elastic#83340) SQL: Add range checks to interval multiplication operation (elastic#83478) Remove DiscoveryNodes#getAllNodes (elastic#83538) Make RoutingNodes behave like a collection (elastic#83540) Remove Unused CS Listener from SecurityServerTransportInterceptor (elastic#83556)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/Aggregations
Aggregations
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
>test
Issues or PRs that are addressing/adding tests
v8.1.0
v8.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes smoke tests my enabling the random_sampler agg
Fixes flakey sampler test
closes #83523
closes #83357