Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] Forward deprecations from search response to transform _preview API response #83253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Transform] Forward deprecations from search response to transform _preview API response #83253

wants to merge 2 commits into from

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Jan 28, 2022 •
edited
Loading

This PR makes sure any deprecation warnings generated by the _search API (which is internally used by _preview API) show up in _preview response.
This is achieved by setting preserveResponseHeaders flag to true.

Relates #82935

@przemekwitek przemekwitek force-pushed the transform_preview_deprecations branch 2 times, most recently from 7650baa to caf4d8e Compare January 28, 2022 12:44
@przemekwitek przemekwitek removed the WIP label Jan 28, 2022
@przemekwitek przemekwitek marked this pull request as ready for review January 28, 2022 13:44
@przemekwitek przemekwitek added the :ml/Transform Transform label Jan 28, 2022
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jan 28, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@hendrikmuhs
Copy link

Looks good,

as for testing: AbstractSerializingTransformTestCase introduces mocked deprecated aggregations. I am not sure this is re-usable for this, as it may not be suitable for integration tests. Otherwise I would look for extending TransformSingleNodeTestCase which uses LocalStateTransform. The later could load a plugin with deprecated aggs?

@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
@elasticsearchmachine
Copy link
Collaborator

Hi @przemekwitek, I've created a changelog YAML for you.

@przemekwitek przemekwitek force-pushed the transform_preview_deprecations branch from f27d10c to cb0cfdb Compare February 3, 2022 13:23
@elasticsearchmachine
Copy link
Collaborator

Hi @przemekwitek, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine changed the base branch from master to main July 22, 2022 23:09
@mark-vieira mark-vieira added v8.5.0 and removed v8.4.0 labels Jul 27, 2022
@csoulios csoulios added v8.6.0 and removed v8.5.0 labels Sep 21, 2022
@droberts195 droberts195 removed the v8.1.0 label Oct 3, 2022
@kingherc kingherc added v8.7.0 and removed v8.6.0 labels Nov 16, 2022
@rjernst rjernst added v8.8.0 and removed v8.7.0 labels Feb 8, 2023
@gmarouli gmarouli added v8.9.0 and removed v8.8.0 labels Apr 26, 2023
@quux00 quux00 added v8.11.0 and removed v8.10.0 labels Aug 16, 2023
@mattc58 mattc58 added v8.12.0 and removed v8.11.0 labels Oct 4, 2023
@mark-vieira mark-vieira added auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :ml/Transform Transform Team:ML Meta label for the ML team >upgrade v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.