Add getMinimalSupportedVersion to QueryBuilders #83208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
javanna
approved these changes
Jan 31, 2022
| @@ -127,6 +128,11 @@ public String getWriteableName() { | |||
| return NAME; | |||
| } | |||
|
|
|||
| @Override | |||
| public Version getMinimalSupportedVersion() { | |||
| return Version.V_EMPTY; | |||
There was a problem hiding this comment.
not too sure when this was introduced. I am thinking during the 7.x series.
There was a problem hiding this comment.
This query builder looks like something used only in tests though, I didn't give those a thorough check.
|
@elasticmachine run elasticsearch-ci/part-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting #81809, we changed query builders to implement 'VersionedNamedWriteable' to be able to detect
when new query builders under the search enpoint are introduced and also to force new implementations to overwrite
'getMinimalSupportedVersion' with a current release version.
This change removes the default implementation in the QueryBuilder interface and replaces it with individual
implementations in the currently existing query builders. For builders that have been around for longer than 7.0 (the
earliest verison constant we currently have around) we use Version.V_EMPTY which sorts always before any other declared version.