Skip to content

Fix PendingReplicationActions Submitting lots of NOOP Tasks to GENERIC #82092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2021
Merged

Fix PendingReplicationActions Submitting lots of NOOP Tasks to GENERIC #82092

merged 1 commit into from
Dec 27, 2021

Conversation

original-brownbear
Copy link
Contributor

@original-brownbear original-brownbear commented Dec 27, 2021 •
edited
Loading

At times sending empty lists to generic here did get quite hot in many shards benchmarks.

extracted from #79837
relates #77466

@original-brownbear
Fix PendingReplicationActions Submitting lots of NOOP Tasks to GENERIC
fb086cd 
At times sending empty lists to generic here did get quite hot in many shards benchmarks.
@original-brownbear original-brownbear added >non-issue :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v8.0.0 v8.1.0 labels Dec 27, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Dec 27, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@original-brownbear
Copy link
Contributor Author

Jenkins run elasticsearch-ci/part-2

henningandersen
henningandersen approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think we should mark this an enhancement, we expect some positive impact from this.

@original-brownbear
Copy link
Contributor Author

Thanks Henning!

I think we should mark this an enhancement, we expect some positive impact from this.

++ done

@original-brownbear original-brownbear merged commit 806dfcb into elastic:master Dec 27, 2021
@original-brownbear original-brownbear deleted the speed-up-pending-repl-actions branch December 27, 2021 20:13
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Dec 27, 2021
@original-brownbear
Fix PendingReplicationActions Submitting lots of NOOP Tasks to GENERIC (
627f104 
elastic#82092)

At times sending empty lists to generic here did get quite hot in many shards benchmarks.
@original-brownbear original-brownbear mentioned this pull request Dec 27, 2021
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.0

elasticsearchmachine pushed a commit that referenced this pull request Dec 27, 2021
@original-brownbear
Fix PendingReplicationActions Submitting lots of NOOP Tasks to GENERIC (
376cc67 
#82092) (#82098)

At times sending empty lists to generic here did get quite hot in many shards benchmarks.
@original-brownbear original-brownbear mentioned this pull request Feb 8, 2022
Merged
@original-brownbear original-brownbear restored the speed-up-pending-repl-actions branch April 18, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningandersen henningandersen henningandersen approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >enhancement Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@original-brownbear @elasticmachine @elasticsearchmachine @henningandersen