Skip to content

[8.0] [ML] Switch message and detail for model snapshot deprecations (#81108) #81114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

droberts195
Copy link
Contributor

Backports the following commits to 8.0:

…ic#81108)

This is a fix to the fix of elastic#81060. In the original fix where I tried to
port the changes from elastic#79387 to master I didn't notice that the text of
the message and detail of the deprecation had been largely switched
around. My tweaks to the wording in elastic#81060 did not make this major
switch. This PR switches the two strings we generate. This is only for
8.0 and 8.1. For 7.16 the discrepancy became obvious in the backport of
elastic#81060 to that branch, so it's already correct there.
@droberts195 droberts195 added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport labels Nov 29, 2021
@droberts195 droberts195 deleted the backport/8.0/pr-81108 branch November 29, 2021 17:45
@droberts195 droberts195 restored the backport/8.0/pr-81108 branch November 29, 2021 17:46
@droberts195 droberts195 reopened this Nov 29, 2021
@elasticsearchmachine elasticsearchmachine merged commit e1341e9 into elastic:8.0 Nov 29, 2021
@droberts195 droberts195 deleted the backport/8.0/pr-81108 branch November 29, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.0.0-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants