[7.16] [ML] Fix datafeed preview with remote indices (#81099) #81104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#77109 a bug was fixed with regard to `date_nanos` time fields and the preview datafeed API. However, that fix introduces a new bug. As we are calling the field caps API to find out whether the time field is `date_nanos`, we are setting the datafeed indices on the request. This may result to erroneous behaviour on local indices and it certainly will result to an error if the datafeed's indices are remote. This commit fixes that problem by setting the datafeed's indices on the field caps request.
dimitris-athanasiou
added
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.16: