Don't apply the spotless plugin to non-applicable projects #80679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 11, 2021
…0679) This is an attempt at resolving, or at least reducing the prevalence of elastic#77837. A more robust solution is probably required, but this should help reduce this problem since we now apply spotless to about 90 fewer subprojects.
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 11, 2021
…0679) This is an attempt at resolving, or at least reducing the prevalence of elastic#77837. A more robust solution is probably required, but this should help reduce this problem since we now apply spotless to about 90 fewer subprojects.
pugnascotia
reviewed
Nov 12, 2021
.../java/org/elasticsearch/gradle/internal/conventions/precommit/FormattingPrecommitPlugin.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at resolving, or at least reducing the prevalence of #77837. A more robust solution is probably required, but this should help reduce this problem since we now apply spotless to about 90 fewer subprojects.