Skip to content

Add field usage support for vectors #80608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Nov 10, 2021

Add field usage tracking support for the new vectors functionality.

@ywelsch ywelsch added >enhancement :Search/Search Search-related issues that do not fall into other categories v8.1.0 labels Nov 10, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Nov 10, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one note regarding possible problem with the rest test for mixed cluster tests

@@ -0,0 +1,87 @@
setup:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test might need a skip section for <8.1 for mixed cluster tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, don't really understand why this passes test. Maybe we don't run these in x-pack on mixed clusters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this validates my understanding (I deliberately did not add the version constraint to check if anything breaks on CI). I find the findings very worrying though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see that we both expected this to fail in some way. Maybe worth some parallel investigation, I'd be interested in the results.

Copy link
Contributor

@mark-vieira mark-vieira Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we don't have "mixed cluster" tests for x-pack like we do for the core apis. So we simply aren't running this test under that scenario at all. See #31096

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's scary (and lol for linking to my own issue, guess my memory is failing me).

Perhaps that one needs to be reprioritized!

Copy link
Contributor

@mark-vieira mark-vieira Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue seems to be tagged as core/infra but I'm not sure if that's strictly correct. There's no real clear ownership of these large cross-functional test suites. It's really just a matter of adding a qa project for this under x-pack similar to the existing core one.

@ywelsch ywelsch merged commit 064936e into elastic:master Nov 15, 2021
@jimczi jimczi mentioned this pull request Nov 23, 2021
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants