Use almalinux as the Docker base image #80524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugnascotia
added
>enhancement
:Delivery/Packaging
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
Hi @pugnascotia, I've created a changelog YAML for you. |
|
Hi @pugnascotia, I've updated the changelog YAML for you. |
|
@elasticmachine run elasticsearch-ci/packaging-tests-windows - looks like transient failures |
mark-vieira
approved these changes
Nov 9, 2021
| @@ -19,7 +19,7 @@ | |||
| add as many newlines here as necessary to improve legibility. | |||
| */ %> | |||
|
|
|||
| <% if (docker_base == "ubi") { %> | |||
| <% if (docker_base == 'default' || docker_base == "ubi") { %> | |||
There was a problem hiding this comment.
I think one of the issues the Dockerhub folks had was with the fact we're using a multi-stage build. Can we eliminate this given all we're doing now in this stage is unpacking ES and adding tini?
There was a problem hiding this comment.
I'll look into this in a separate PR.
pugnascotia
added a commit
that referenced
this pull request
Nov 10, 2021
Closes #76681. Our approach to using `scratch` for building Docker images has caused problems at Docker Hub. Fix this situation by removing the whole process of using scratch and instead bases the default distribution on `almalinux:8.4-minimal`. Alma Linux is binary-compatible with RHEL, and therefore very similar to UBI.
|
I had to make another fix to the Dockerfile in 46dc92d. |
pugnascotia
added a commit
that referenced
this pull request
Nov 18, 2021
pugnascotia
added a commit
that referenced
this pull request
Nov 18, 2021
Closes #76681. Our approach to using `scratch` for building Docker images has caused problems at Docker Hub. Fix this situation by removing the whole process of using scratch and instead bases the default distribution on `almalinux:8.4-minimal`. Alma Linux is binary-compatible with RHEL, and therefore very similar to UBI.
pugnascotia
added a commit
that referenced
this pull request
Nov 18, 2021
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76681. Our approach to using
scratchfor building Docker images has caused problems at Docker Hub. Fix this situation by removing the whole process of using scratch and instead bases the default distribution onalmalinux:8.4-minimal. Alma Linux is binary-compatible with RHEL, and therefore very similar to UBI.cc @bytebilly @mieciu