Skip to content

Fix "outer" max_docs documentation #80436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

jakelandis
Copy link
Contributor

@jakelandis jakelandis commented Nov 5, 2021

This commit fixes a documentation bug that lists 'max_docs'
nested under source it should live at the same level as source

related: #43373


Note - I have set auto-back port to all branches that this will apply cleanly. It looks like the change could be applied back to 7.3, but anything prior to 7.13 I don't think will merge cleanly without manual intervention.

Preview: https://elasticsearch_80436.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/docs-reindex.html#docs-reindex-api-request-body

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Our policy is to backport to the actively-maintained branches. With the auto-backport tool, if we can backport to additional branches, that's a bonus. (When it works, great, if it doesn't we should fall back to the usual maintenance policy.)

@jakelandis jakelandis merged commit 41e520e into elastic:master Nov 8, 2021
@jakelandis jakelandis deleted the reindex_doc_fix branch November 8, 2021 13:58
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs'
nested under source it should live at the same level as source

related: elastic#43373
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs'
nested under source it should live at the same level as source

related: elastic#43373
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs'
nested under source it should live at the same level as source

related: elastic#43373
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs'
nested under source it should live at the same level as source

related: elastic#43373
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0
7.13
7.14
7.16
7.15

jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs'
nested under source it should live at the same level as source

related: elastic#43373
elasticsearchmachine pushed a commit that referenced this pull request Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs'
nested under source it should live at the same level as source

related: #43373
elasticsearchmachine pushed a commit that referenced this pull request Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs'
nested under source it should live at the same level as source

related: #43373
elasticsearchmachine pushed a commit that referenced this pull request Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs'
nested under source it should live at the same level as source

related: #43373
elasticsearchmachine pushed a commit that referenced this pull request Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs'
nested under source it should live at the same level as source

related: #43373
elasticsearchmachine pushed a commit that referenced this pull request Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs'
nested under source it should live at the same level as source

related: #43373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants