Skip to content

[DOCS] if_version parameter for OCC on pipeline updates #79640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 25, 2021

Conversation

danhermann
Copy link
Contributor

@danhermann danhermann commented Oct 21, 2021

@danhermann danhermann added >docs General docs changes :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.16.0 labels Oct 21, 2021
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Oct 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@danhermann
Copy link
Contributor Author

@elasticmachine update branch

@danhermann danhermann requested a review from jrodewig October 21, 2021 16:21
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM.

We should probably make a related update to https://www.elastic.co/guide/en/elasticsearch/reference/master/ingest.html#manage-pipeline-versions

Right now, the docs state that ES doesn't use the pipeline version. That's no longer true. It'd be good document this parameter and the new incrementation there.

Let me know if you'd like me to handle that in a separate PR.

@danhermann
Copy link
Contributor Author

This change LGTM.

We should probably make a related update to https://www.elastic.co/guide/en/elasticsearch/reference/master/ingest.html#manage-pipeline-versions

Right now, the docs state that ES doesn't use the pipeline version. That's no longer true. It'd be good document this parameter and the new incrementation there.

Let me know if you'd like me to handle that in a separate PR.

@jrodewig, thanks for catching that other mention of pipeline versions. I've updated that one as well and will merge this one if you think it looks good.

@jrodewig
Copy link
Contributor

jrodewig commented Oct 22, 2021

Thanks @danhermann. Looking at #78551, it seems like we also automatically increment the version numbers now. Can we update the docs to note that as well?

I didn't test this locally so let me know if I misunderstood the PR or code.

@danhermann
Copy link
Contributor Author

Thanks @danhermann. Looking at #78551, it seems like we also automatically increment the version numbers now. Can we update the docs to note that as well?

I didn't test this locally so let me know if I misunderstood the PR or code.

You're right. I updated the docs to mention that as well as updated one more spot where we said that the version attribute was not used by ES.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one minor typo. Thanks!

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
@danhermann danhermann merged commit a23f58f into elastic:master Oct 25, 2021
@danhermann
Copy link
Contributor Author

Thanks, @jrodewig!

@danhermann danhermann deleted the docs_for_78551_pipeline_occ branch October 25, 2021 13:25
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 28, 2021
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants