-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[DOCS] if_version
parameter for OCC on pipeline updates
#79640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] if_version
parameter for OCC on pipeline updates
#79640
Conversation
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-data-management (Team:Data Management) |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change LGTM.
We should probably make a related update to https://www.elastic.co/guide/en/elasticsearch/reference/master/ingest.html#manage-pipeline-versions
Right now, the docs state that ES doesn't use the pipeline version
. That's no longer true. It'd be good document this parameter and the new incrementation there.
Let me know if you'd like me to handle that in a separate PR.
@jrodewig, thanks for catching that other mention of pipeline versions. I've updated that one as well and will merge this one if you think it looks good. |
Thanks @danhermann. Looking at #78551, it seems like we also automatically increment the version numbers now. Can we update the docs to note that as well? I didn't test this locally so let me know if I misunderstood the PR or code. |
You're right. I updated the docs to mention that as well as updated one more spot where we said that the version attribute was not used by ES. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from one minor typo. Thanks!
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Thanks, @jrodewig! |
Preview URLS:
https://elasticsearch_79640.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/put-pipeline-api.html
https://elasticsearch_79640.docs-preview.app.elstc.co/diff
Relates to #78551