Disallow kNN searches on nested vector fields #79403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
:Search/Search
jtibshirani
commented
Oct 18, 2021
| search: | ||
| rest_total_hits_as_int: true | ||
| index: test-index | ||
| knn_search: |
There was a problem hiding this comment.
There are extra changes here because I caught and fixed some mistakes in these REST tests.
|
Pinging @elastic/es-search (Team:Search) |
mayya-sharipova
approved these changes
Oct 20, 2021
| @@ -28,6 +42,9 @@ setup: | |||
| body: | |||
| name: moose.jpg | |||
| vector: [-0.5, 100.0, -13, 14.8, -156.0] | |||
| comments: | |||
| - body: "what a great moose" | |||
There was a problem hiding this comment.
cool descriptions!!!
There was a problem hiding this comment.
hehe, I got bored with my usual test examples :)
| * `bar.baz`, then calling this method with `foo.bar.baz` will return | ||
| * the path `foo`, skipping over the object-but-not-nested `foo.bar` | ||
| */ | ||
| public String getNestedParent(String path) { |
There was a problem hiding this comment.
it seems that the previous getNestedParent will return null if path is not an objectMapper? But from how this method was used, it looks like this check is not important. So this change LGTM.
There was a problem hiding this comment.
Right, this behavior is different but I also couldn't find any place where this check was important.
romseygeek
approved these changes
Oct 20, 2021
|
Thank you both for reviews. |
jtibshirani
added
:Search Relevance/Vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new kNN endpoint currently doesn't support searches on nested fields. This
PR updates the validation logic to detect this case and throw a clear error. It
also adds tests for kNN search when there are nested documents.
Relates to #78473.