Do not create unused testCluster #77581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
breskeby
force-pushed
the
create-less-unused-cluster
branch
2 times, most recently
from
e6120e2 to
11b90e2
Compare
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
force-pushed
the
create-less-unused-cluster
branch
4 times, most recently
from
8e127c4 to
eca88f7
Compare
breskeby
force-pushed
the
create-less-unused-cluster
branch
from
8bf6eaf to
354687b
Compare
breskeby
commented
Sep 21, 2021
| @@ -20,8 +20,8 @@ dependencies { | |||
| } | |||
|
|
|||
| for (Version bwcVersion : BuildParams.bwcVersions.wireCompatible) { | |||
| String baseName = "v${bwcVersion}" | |||
There was a problem hiding this comment.
This solves a problem with for loops and lazy evaluated strings that causes late resolved GStrings to only contain the last bwcVersion of the for loop
There was a problem hiding this comment.
Ug, I've been bitten by that so many times.
pugnascotia
approved these changes
Sep 21, 2021
|
@elasticmachine run elasticsearch-ci/part-2 |
mark-vieira
approved these changes
Sep 21, 2021
This avoids creating test clusters that are not required during the build. We use lazy configuration here on testClusters and only instantiate them as theyre
provide useCluster(Provider) method to TestClusterAware Ideally we take this a step further and realize those test clusters only on use. But out of scope of this PR.
breskeby
force-pushed
the
create-less-unused-cluster
branch
from
65d79aa to
f7dab15
Compare
breskeby
added
the
auto-merge-without-approval
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Sep 27, 2021
* Do not create unused testCluster This avoids creating test clusters that are not required during the build. We use lazy configuration here on testClusters and only instantiate them as theyre * Do not fail on run task (debug) * Create more test cluster lazy * Make more test cluster lazy * Avoid creating unused testcluster * Fix PluginBuildPlugin * Fix disabling geo db download * Fix cluster setup in repository-multi-version * Polishing * Fix issue with irretic groovy ogic * Fix bwc tests * Fix more bwcTests * Fix more bwc tests * Fix more bwc tests * Fix more bwc tests * Fix typo * Minor polishing * Fix rolling upgrade tests * Fix cluster config in sql qa mixedcluster project * Fix more bwc tests * Clean up before review * Document test cluster usage * Api polising after Review provide useCluster(Provider) method to TestClusterAware Ideally we take this a step further and realize those test clusters only on use. But out of scope of this PR. * Allow gradle provider as value for nonSystemProperties * Some simplification on test configuration * Fix typo in rest test config * Fix more typos * Fix another typo * Fix more typos
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Do not create unused testCluster (#77581) * Do not create unused testCluster This avoids creating test clusters that are not required during the build. We use lazy configuration here on testClusters and only instantiate them as theyre * Do not fail on run task (debug) * Create more test cluster lazy * Make more test cluster lazy * Avoid creating unused testcluster * Fix PluginBuildPlugin * Fix disabling geo db download * Fix cluster setup in repository-multi-version * Polishing * Fix issue with irretic groovy ogic * Fix bwc tests * Fix more bwcTests * Fix more bwc tests * Fix more bwc tests * Fix more bwc tests * Fix typo * Minor polishing * Fix rolling upgrade tests * Fix cluster config in sql qa mixedcluster project * Fix more bwc tests * Clean up before review * Document test cluster usage * Api polising after Review provide useCluster(Provider) method to TestClusterAware Ideally we take this a step further and realize those test clusters only on use. But out of scope of this PR. * Allow gradle provider as value for nonSystemProperties * Some simplification on test configuration * Fix typo in rest test config * Fix more typos * Fix another typo * Fix more typos * Fix runEqlCorrectnessNode run task and cluster configuration (#78249) * Fix merge issue * Fix bwc tests after backporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids creating test clusters that are not required during the build.
We use lazy configuration here on testClusters and only instantiate them as required.
Also updated BUILDING.MD giving hints on using test cluster plugin properly