Skip to content

Handle a edge case for validation of API key role descriptors #76959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Aug 26, 2021

This PR fixes a BWC edge case: In a mixed cluster, e.g. rolling upgrade, API keys can sometimes fail to validate due to mismatch of role descriptors depending on where the request is initially authenticated.

@ywangd ywangd requested a review from tvernum August 26, 2021 03:42
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Aug 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for tracking this one down.

@ywangd ywangd merged commit 21230cb into elastic:master Aug 26, 2021
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Aug 26, 2021
…c#76959)

This PR fixes a BWC edge case: In a mixed cluster, e.g. rolling upgrade, API
keys can sometimes fail to validate due to mismatch of role descriptors
depending on where the request is initially authenticated.
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Aug 26, 2021
…c#76959)

This PR fixes a BWC edge case: In a mixed cluster, e.g. rolling upgrade, API
keys can sometimes fail to validate due to mismatch of role descriptors
depending on where the request is initially authenticated.
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Aug 26, 2021
…c#76959)

This PR fixes a BWC edge case: In a mixed cluster, e.g. rolling upgrade, API
keys can sometimes fail to validate due to mismatch of role descriptors
depending on where the request is initially authenticated.
elasticsearchmachine pushed a commit that referenced this pull request Aug 26, 2021
#76962)

This PR fixes a BWC edge case: In a mixed cluster, e.g. rolling upgrade, API
keys can sometimes fail to validate due to mismatch of role descriptors
depending on where the request is initially authenticated.
elasticsearchmachine pushed a commit that referenced this pull request Aug 26, 2021
#76961)

This PR fixes a BWC edge case: In a mixed cluster, e.g. rolling upgrade, API
keys can sometimes fail to validate due to mismatch of role descriptors
depending on where the request is initially authenticated.
elasticsearchmachine pushed a commit that referenced this pull request Aug 26, 2021
#76963)

* Handle a edge case for validation of API key role descriptors (#76959)

This PR fixes a BWC edge case: In a mixed cluster, e.g. rolling upgrade, API
keys can sometimes fail to validate due to mismatch of role descriptors
depending on where the request is initially authenticated.

* checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Security/Security Security issues without another label Team:Security Meta label for security team v7.14.1 v7.15.0 v7.16.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants