Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle wrapper to 7.2 #75894

Merged

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Jul 30, 2021

Update to latest Gradle release and fix new deprecation warnings

@breskeby breskeby self-assigned this Jul 30, 2021
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.15.0 v8.0.0 labels Jul 30, 2021
@breskeby breskeby changed the title Update Gradle wrapper to 7.2-rc-1 Update Gradle wrapper to 7.2 Jul 30, 2021
@breskeby
Copy link
Contributor Author

breskeby commented Aug 5, 2021

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

merge conflict between base and head

@breskeby breskeby force-pushed the update-gradle-wrapper-7-2 branch from 49aa3e9 to d19aa63 Compare August 5, 2021 20:41
@breskeby breskeby force-pushed the update-gradle-wrapper-7-2 branch from e289cbc to e57bcbf Compare August 18, 2021 08:15
@breskeby breskeby added the auto-backport Automatically create backport pull requests when merged label Aug 18, 2021
String compilerVersionInfoPath = minimumCompilerVersionPath(unreleasedVersionInfo.get().version);
String minimumCompilerVersion = readFromFile(new File(checkoutDir.get(), compilerVersionInfoPath));
loggedExec.environment("JAVA_HOME", getJavaHome(Integer.parseInt(minimumCompilerVersion)));
loggedExec.doFirst(new Action<Task>() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lambdas as task actions are now deprecated. therefore we do not need a comment here as the build would fail to signal this anyhow

@breskeby breskeby added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 18, 2021
@breskeby breskeby marked this pull request as ready for review August 18, 2021 08:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine elasticsearchmachine merged commit 86a5772 into elastic:master Aug 18, 2021
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run backport --upstream elastic/elasticsearch --pr 75894

breskeby added a commit to breskeby/elasticsearch that referenced this pull request Aug 18, 2021
* Update Gradle wrapper to 7.2-rc-1

Fix deprecation warnings on the go

* Remove deprecated lambda based Gradle task actions

* Remove usage of deprecated BasePluginConvention

* Update wrapper to 7.2-rc-2

* Update gradle wrapper to 7.2-rc-3

* Update gradle wrapper to 7.2
breskeby added a commit that referenced this pull request Aug 18, 2021
@breskeby breskeby deleted the update-gradle-wrapper-7-2 branch December 10, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.15.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants