Yaml tests for range family aggregations #75434
Conversation
not-napoleon
added
>test
|
@elasticmachine update branch |
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
These'd be shorter in yaml. You know you can send yaml in curl if you want too. It works.
There was a problem hiding this comment.
I didn't know you could send yaml in curl, actually. I'll have to try that the next time I'm messing around with it. This is the result of me copy/pasting an existing test. If you feel strongly about it, I'll clean it up, otherwise I don't think it's a big deal if it sits like this for a while.
|
|
||
| - do: | ||
| cluster.health: | ||
| wait_for_status: green |
There was a problem hiding this comment.
We actually wait for yellow by default which is enough. I think these are mostly left over from the before times.
There was a problem hiding this comment.
yeah, again, I just copied what the existing test did.
| body: { "date" : 3000 } | ||
|
|
||
| - do: | ||
| indices.refresh: {} |
There was a problem hiding this comment.
It'd be a little more readable to do this with bulk and a single refresh. Maybe even a little faster.
|
|
||
| - do: | ||
| search: | ||
| rest_total_hits_as_int: true |
There was a problem hiding this comment.
At some point we're going to deprecate this thing so I'd try to avoid adding it to master. It is sort of required if you are running these against 6.x, but maybe only add on backport? I dunno.
There was a problem hiding this comment.
Ugh, I hadn't even thought of that. We use that all over the place in these tests
…icsearch into date-range-rest-tests
|
@elasticmachine update branch |
# Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.aggregation/40_range.yml
Relates to #26220
We already had some tests for Date, Numeric, and IP ranges. This PR breaks them out into three yaml files, and adds coverage for options and modes we weren't exercising before.