Skip to content

[Rest Api Compatibility] Voting config exclusion exception message #75406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

pgomulka
Copy link
Contributor

the exception message has changed in #55291. This is not covered by rest
api compatibility, so no need to return the old message for v7 requests.
This commit adds a transformation to allow for the 7.x test to pass with
a new exception message

relates #51816

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

the exception message has changed in elastic#55291. This is not covered by rest
api compatibility, so no need to return the old message for v7 requests.
This commit adds a transformation to allow for the 7.x test to pass with
a new exception message

relates elastic#51816
@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels Jul 16, 2021
@pgomulka pgomulka self-assigned this Jul 16, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka requested a review from joegallo July 16, 2021 07:25
@joegallo
Copy link
Contributor

So the previous version of this API accepted a node filter as a path argument.

That is, POST _cluster/voting_config_exclusions/<some_node_name>,<some_other_node_id> would have worked. So would have a large variety of other node filters, but the key thing about this example is that it actually could be translated to invocations of the current API.

What do you think about that? We could 'just' return an error (and I absolutely think that's defensible). OR, when we receive the parameter, we could inspect it to figure out if it's something we can translate into the current API, and then run it.

I'm on the fence about whether I think would be a good path to go down or not.

/cc @jakelandis @DaveCTurner

Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit 838e8d8 into elastic:master Jul 26, 2021
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
…lastic#75406)

the exception message has changed in elastic#55291. This is not covered by rest
api compatibility, so no need to return the old message for v7 requests.
This commit adds a transformation to allow for the 7.x test to pass with
a new exception message

relates elastic#51816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants