Skip to content

[Rest Api Compatibility] Dummy REST action for indices.upgrade api #75136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 9, 2021

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jul 8, 2021

indices upgrade api (/_upgrade or /{index}/_upgrade) was removed and _reindex is suggested to be used instead.
There is no easy way to translate _upgrade request to _reindex requests. The dummy Upgrade action will return an exception to a user with a message indicating that _reindex should be used.

upgrade api removal #64732
relates #51816

@pgomulka pgomulka changed the title Compat/upgrade api [Rest Api Compatibility] Dummy REST action for indices.upgrade api Jul 8, 2021
@pgomulka pgomulka added the :Core/Infra/REST API REST infrastructure and utilities label Jul 8, 2021
@pgomulka pgomulka self-assigned this Jul 8, 2021
@pgomulka pgomulka requested review from joegallo and jakelandis July 8, 2021 15:49
@pgomulka pgomulka marked this pull request as ready for review July 8, 2021 15:49
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

'indices.stats/20_translog/Translog stats on closed indices without soft-deletes',

// upgrade api will only get a dummy endpoint returning an exception suggesting to use _reindex
'indices.upgrade/10_basic/Basic test for upgrade indices',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be indices.upgrade/*/* ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants