Remove xpack actions for vector field #75017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have already decided not to have xpack usage for field mappers (see elastic#53076). As mappings stats of all fields is already tracked in cluster stats. Moreover xpack usage for vector field is a quite expensive operation (see elastic#74974). This removes xpack actions for vector field.
mayya-sharipova
added
the
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
@elasticmachine run elasticsearch-ci/part-2 |
|
@elasticmachine run |
jtibshirani
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
Looks good to me. It seems okay to backport to 7.15, since in previous PRs we determined this doesn't count as an API break (#69487).
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Jul 13, 2021
We have already decided not to have xpack usage for field mappers (see elastic#53076). As mappings stats of all fields is already tracked in cluster stats. Moreover xpack usage for vector field is a quite expensive operation (see elastic#74974). This removes xpack actions for vector field. Backport for elastic#75017
mayya-sharipova
added a commit
that referenced
this pull request
Jul 13, 2021
jtibshirani
added
:Search Relevance/Vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have already decided not to have xpack usage for field mappers
(see #53076). As mappings stats of all fields is already tracked
in cluster stats.
Moreover xpack usage for vector field is a quite expensive operation
(see #74974).
This removes xpack actions for vector field.