Skip to content

[DOCS] SQL: Move string fn null/edge handling to arg descriptions #74255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2021
Merged

[DOCS] SQL: Move string fn null/edge handling to arg descriptions #74255

merged 1 commit into from
Jun 17, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Jun 17, 2021 •
edited
Loading

#74201 documents null handling to the arg descriptions of several string functions.

This PR moves pre-existing docs for null handling and similar edge case handling for string functions to arg descriptions for consistency.

Relates to #74193

Preview

https://elasticsearch_74255.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/sql-functions-string.html

@jrodewig jrodewig changed the title [DOCS] SQL: Move null handling to arg descriptions [DOCS] SQL: Move null/edged handling to arg desc for string functions Jun 17, 2021
@jrodewig jrodewig changed the title [DOCS] SQL: Move null/edged handling to arg desc for string functions [DOCS] SQL: Move string function null/edge handling to arg descriptions Jun 17, 2021
@jrodewig jrodewig changed the title [DOCS] SQL: Move string function null/edge handling to arg descriptions [DOCS] SQL: Move string function null/edge handling to arg descriptions Jun 17, 2021
@jrodewig
[DOCS] SQL: Move null handling to arg descriptions
17ec07a 
#74201 documents `null` handling  to the arg descriptions of several string functions.

This PR moves pre-existing docs for `null` handling and similar edge case handling for string functions to arg descriptions for consistency.

Relates to #74193
@jrodewig jrodewig requested a review from matriv June 17, 2021 16:48
@jrodewig jrodewig marked this pull request as ready for review June 17, 2021 16:51
@elasticmachine elasticmachine added Team:QL (Deprecated) Meta label for query languages team Team:Docs Meta label for docs team labels Jun 17, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig changed the title [DOCS] SQL: Move string function null/edge handling to arg descriptions [DOCS] SQL: Move string fn null/edge handling to arg descriptions Jun 17, 2021
costin
costin approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig
Copy link
Contributor Author

Thanks @costin @matriv

@jrodewig jrodewig merged commit 853f243 into elastic:master Jun 17, 2021
@jrodewig jrodewig deleted the docs__sql-reformat-string-fn-null branch June 17, 2021 19:50
This was referenced Jun 17, 2021
Merged
Merged
Merged
jrodewig added a commit that referenced this pull request Jun 17, 2021
@jrodewig
[DOCS] SQL: Move null handling to arg descriptions (#74255) (#74261)
ea0dd00 
#74201 documents `null` handling  to the arg descriptions of several string functions.

This PR moves pre-existing docs for `null` handling and similar edge case handling for string functions to arg descriptions for consistency.

Relates to #74193
jrodewig added a commit that referenced this pull request Jun 17, 2021
@jrodewig
[DOCS] SQL: Move null handling to arg descriptions (#74255) (#74262)
148bd3d 
#74201 documents `null` handling  to the arg descriptions of several string functions.

This PR moves pre-existing docs for `null` handling and similar edge case handling for string functions to arg descriptions for consistency.

Relates to #74193
jrodewig added a commit that referenced this pull request Jun 17, 2021
@jrodewig
[DOCS] SQL: Move null handling to arg descriptions (#74255) (#74263)
7bb4c86 
#74201 documents `null` handling  to the arg descriptions of several string functions.

This PR moves pre-existing docs for `null` handling and similar edge case handling for string functions to arg descriptions for consistency.

Relates to #74193
@jrodewig jrodewig mentioned this pull request Jun 22, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin costin costin approved these changes

@matriv matriv Awaiting requested review from matriv

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v7.12.2 v7.13.3 v7.14.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrodewig @elasticmachine @costin @jakelandis