-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[DOCS] Clone index API doesn't apply index templates or settings #74138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jrodewig
merged 1 commit into
elastic:master
from
jrodewig:docs__clarify-clone-index-settings
Jun 15, 2021
Merged
[DOCS] Clone index API doesn't apply index templates or settings #74138
jrodewig
merged 1 commit into
elastic:master
from
jrodewig:docs__clarify-clone-index-settings
Jun 15, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * Notes that Elasticsearch doesn't apply index templates to cloned indices. * Notes the clone API doesn't copy index settings.
Pinging @elastic/es-core-features (Team:Core/Features) |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jun 15, 2021
jrodewig
added a commit
that referenced
this pull request
Jun 15, 2021
) (#74152) Changes: * Notes that Elasticsearch doesn't apply index templates to cloned indices. * Notes the clone API doesn't copy index settings.
jrodewig
added a commit
that referenced
this pull request
Jun 15, 2021
) (#74153) Changes: * Notes that Elasticsearch doesn't apply index templates to cloned indices. * Notes the clone API doesn't copy index settings.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 16, 2021
In elastic#74138 we noted that index settings aren't copied in a clone. In fact that's not true, we copy everything except explicitly-excluded ones, `number_of_replicas` and `auto_expand_replicas`. This fixes the mistake.
DaveCTurner
added a commit
that referenced
this pull request
Jun 16, 2021
In #74138 we noted that index settings aren't copied in a clone. In fact that's not true, we copy everything except explicitly-excluded ones, `number_of_replicas` and `auto_expand_replicas`. This fixes the mistake. Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
DaveCTurner
added a commit
that referenced
this pull request
Jun 16, 2021
In #74138 we noted that index settings aren't copied in a clone. In fact that's not true, we copy everything except explicitly-excluded ones, `number_of_replicas` and `auto_expand_replicas`. This fixes the mistake. Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
DaveCTurner
added a commit
that referenced
this pull request
Jun 16, 2021
In #74138 we noted that index settings aren't copied in a clone. In fact that's not true, we copy everything except explicitly-excluded ones, `number_of_replicas` and `auto_expand_replicas`. This fixes the mistake. Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/Indices APIs
APIs to create and manage indices and templates
:Distributed Indexing/CRUD
A catch all label for issues around indexing, updating and getting a doc by id. Not search.
>docs
General docs changes
Team:Data Management
Meta label for data/management team
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Team:Docs
Meta label for docs team
v7.13.3
v7.14.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Closes #74135
Preview
https://elasticsearch_74138.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/indices-clone-index.html#clone-index-api-desc